Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Empty adjoint plots in bokeh #1561

Merged
merged 1 commit into from Jun 17, 2017
Merged

Added support for Empty adjoint plots in bokeh #1561

merged 1 commit into from Jun 17, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 17, 2017

This was already handled correctly by matplotlib but #1478 highlighted that bokeh did not handle padding for empty adjoints correctly. Also added a unit test, and here is an example:

hv.AdjointLayout([hv.Curve([0,1,1,2,3]), hv.Empty() ,hv.Curve([0,1,1,0,1])(plot=dict(height=100))])

screen shot 2017-06-17 at 2 10 35 pm

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jun 17, 2017

Looks good. Happy to merge if it is ready and the tests turn green.

@jlstevens jlstevens merged commit e258f78 into master Jun 17, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 79.285%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the empty_adjoints branch Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants