Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ArrowPlot implementation for bokeh #1608

Merged
merged 2 commits into from Jun 26, 2017
Merged

Add ArrowPlot implementation for bokeh #1608

merged 2 commits into from Jun 26, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 26, 2017

Although we want to make Arrow more general in the future this PR adds support for the current Arrow in bokeh. Here is a comparison between the mpl and bokeh arrows: https://anaconda.org/philippjfr/arrow/notebook

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jun 26, 2017

Great!

I suggest merging this ASAP and rebasing into the getting_started PR. Then you can test it works well by creating the bokeh Arrow notebook and updating the dropdown_economic bokeh demo (which is currently using VLines to get around the lack of Arrow support).

@philippjfr philippjfr force-pushed the arrow_bokeh branch from 98ece52 to 8bc9aee Jun 26, 2017
@philippjfr philippjfr force-pushed the arrow_bokeh branch from 8bc9aee to e13dad5 Jun 26, 2017
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jun 26, 2017

pr build passing. Merging.

@jlstevens jlstevens merged commit f33580c into master Jun 26, 2017
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 79.852%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the arrow_bokeh branch Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants