Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Bounds to BoundsXY for consistency #1672

Merged
merged 1 commit into from Jul 5, 2017
Merged

Conversation

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jul 3, 2017

PR title says everything other than the fact that Bounds still exists as an alias (with a deprecation warning).

@jlstevens jlstevens added this to the v1.8.1 milestone Jul 3, 2017
@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented Jul 5, 2017

@philippjfr Ready to merge if you are happy with this PR.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jul 5, 2017

Looks good, would be good if we could decide on what timeframe deprecations should happen and perhaps leave searchable comments marking deprecations with the release when we expect the feature to be removed. Will just merge this though.

@philippjfr philippjfr merged commit ff2cc18 into master Jul 5, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on bounds_deprecation at 79.67%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the bounds_deprecation branch Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants