Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise SkipRendering error when plotting nested layouts #1687

Merged
merged 1 commit into from Jul 6, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jul 6, 2017

Adds a SkipRendering error when trying to display a Layout of NdLayouts. Fixes #1678

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jul 6, 2017

Great! Happy to merge but first I want to check matplotlib does this too...

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jul 6, 2017

Merging. Does matplotlib also raise SkipRendering in this situation?

@jlstevens jlstevens merged commit 199ea09 into master Jul 6, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on skip_nested_layout_render at 79.689%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the skip_nested_layout_render branch Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants