Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled bokeh log axes with axis lower bound <=0 #1691

Merged
merged 1 commit into from Jul 7, 2017
Merged

Handled bokeh log axes with axis lower bound <=0 #1691

merged 1 commit into from Jul 7, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jul 7, 2017

Addresses #1679. If the range lower bound is <= 0, it uses a lower bound of 0.01 unless the upper bound is <0.01, in which case it backs up to a value one decimal point lower than the upper value.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jul 7, 2017

Should it warn? Isn't 0.01 an arbitrary value?

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jul 7, 2017

Nevermind, I see you have a warning in there.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jul 7, 2017

@philippjfr Ready to merge?

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jul 7, 2017

Yes.

@jlstevens jlstevens merged commit 9b565a3 into master Jul 7, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 79.682%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the log_zeros branch Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants