Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define default group on Dataset #1724

Merged
merged 1 commit into from Jul 15, 2017
Merged

Define default group on Dataset #1724

merged 1 commit into from Jul 15, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jul 14, 2017

Simple oversight which results in some bad behaviors when inheriting the groups for some operations.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jul 15, 2017

Looks fine. Merging.

@jlstevens jlstevens merged commit 040d1a2 into master Jul 15, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on dataset_group at 79.627%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the dataset_group branch Jul 31, 2017
@jlstevens jlstevens added this to the 1.8.2 milestone Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants