Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs and minor code fixes #1759

Merged
merged 3 commits into from Jul 27, 2017
Merged

Conversation

@ea42gh
Copy link
Contributor

@ea42gh ea42gh commented Jul 27, 2017

hope this works:
changed __call__ to .opts() in 3 files

jordansamuels pushed a commit to jordansamuels/holoviews that referenced this pull request Jul 27, 2017
* Complements holoviz#1759
* Execute `git grep -lE '\)\((style|plot|norm)=' -- examples | xargs  perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'`
* Spot check notebooks
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jul 27, 2017

@ea42gh @jordansamuels Thank you both - this is really helpful!

I wasn't looking forward to updating all these references myself but you two seem to have sorted it out! Skimming the diff here, the changes all look right but I'll have another pass before merging.

This PR should probably be merged first and then I can review and merge @jordansamuels PR.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jul 27, 2017

Yup, all looks good!

Merging.

@jlstevens jlstevens merged commit dcf4a61 into holoviz:master Jul 27, 2017
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 79.611%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
jordansamuels pushed a commit to jordansamuels/holoviews that referenced this pull request Jul 27, 2017
* __call__ to .opts() mods

* __call__ to .opts() mods

* __call__ to .opts() mods
jordansamuels pushed a commit to jordansamuels/holoviews that referenced this pull request Jul 27, 2017
* Complements holoviz#1759
* Execute `git grep -lE '\)\((style|plot|norm)=' -- examples | xargs  perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'`
* Spot check notebooks
@jordansamuels jordansamuels mentioned this pull request Jul 27, 2017
jlstevens added a commit that referenced this pull request Jul 27, 2017
* Replace (...) with .opts()

* Complements #1759
* Execute `git grep -lE '\)\((style|plot|norm)=' -- examples | xargs  perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'`
* Spot check notebooks

* A few more cases thanks to @ea42gh

* Manually search `git grep ')(' -- examples | grep -vE '.{255}'
* Fix cases by hand
`
@jlstevens jlstevens added this to the 1.8.2 milestone Aug 21, 2017
jsignell added a commit to pyviz-topics/examples that referenced this pull request May 6, 2019
* Replace (...) with .opts()

* Complements holoviz/holoviews#1759
* Execute `git grep -lE '\)\((style|plot|norm)=' -- examples | xargs  perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'`
* Spot check notebooks

* A few more cases thanks to @ea42gh

* Manually search `git grep ')(' -- examples | grep -vE '.{255}'
* Fix cases by hand
`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants