Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to setup.py for pip install #1782

Merged
merged 4 commits into from Aug 3, 2017
Merged

Fixes to setup.py for pip install #1782

merged 4 commits into from Aug 3, 2017

Conversation

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Aug 3, 2017

PR to try and address #1734 and #1659.

@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented Aug 3, 2017

Testing in a clean env using:

pip install https://github.com/ioam/holoviews/archive/setup_fixes.zip

Suggests that #1734 is fixed (no more initial numpy error). I'm not yet sure what to do about #1659 though...

@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented Aug 3, 2017

It looks like the issue with the examples function was the cause of the problems in #1659 as well. @philippjfr If you believe it is fixed now, I think it is ready to review/merge.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 3, 2017

Thanks for fixing this, I know it was a pain.

@philippjfr philippjfr merged commit 5e06bb2 into master Aug 3, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 79.621%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented Aug 3, 2017

I'm glad duplicating the example function was sufficient! I was expecting it to get a lot worse!

ea42gh added a commit to ea42gh/holoviews that referenced this pull request Aug 12, 2017
* Moved examples function to setup.py to avoid dependencies install

* Restored copy of examples function in util

* Added comment about duplication of the examples function

* Fixed message about holoviews command dependencies
@jlstevens jlstevens added this to the 1.8.2 milestone Aug 21, 2017
@jlstevens jlstevens deleted the setup_fixes branch Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants