Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram improvements #1836

Merged
merged 15 commits into from Oct 31, 2017
Merged

Histogram improvements #1836

merged 15 commits into from Oct 31, 2017

Conversation

philippjfr
Copy link
Member

Cleaned up and made various outstanding fixes for PR #1784.

@philippjfr
Copy link
Member Author

@jlstevens I've now got this passing. Do you still want a label_format parameter as you suggested in the original PR?

@jlstevens
Copy link
Contributor

I still think the label_format idea is a good one, so it would be nice to include if it doesn't add too much additional work.

@philippjfr
Copy link
Member Author

Not sure I like label_format for this, since it's the value dimension label but could be confused with the regular label. Not sure I have much better suggestions though since I don't like vdim_label.

@jlstevens
Copy link
Contributor

So your issue is not with the idea, just the parameter name? How aboutbinned_format or aggregate_label or something like that?

@philippjfr
Copy link
Member Author

frequency_format is probably the most correct. Is that too long?

@jlstevens
Copy link
Contributor

It is a bit long but I think it is ok. I'll try to think of something shorter but if I can't come up with anything, it will do.

@philippjfr
Copy link
Member Author

Actually I probably prefer frequency_label.

@philippjfr
Copy link
Member Author

Tests are now passing (apart from a single transient), so I'll merge. @timothydmorton Thanks again for contributing, sorry this took so long to merge but it'll be in the next release.

@philippjfr philippjfr merged commit 2782cfd into master Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants