Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for reverse sort of tabular data #1843

Merged
merged 2 commits into from Sep 4, 2017
Merged

Added support for reverse sort of tabular data #1843

merged 2 commits into from Sep 4, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 3, 2017

Add support for reverse sort to tabular interfaces as requested in #1167. Adds a reverse argument to the Dataset.sort method, alternatively could rename it ascending.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 3, 2017

Personally, I'm ok with reverse as I assume normal sort is ascending.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Sep 4, 2017

In that case this is ready to merge, I've added a blurb about it in the Tabular Data user guide.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 4, 2017

Looks good. Merging.

@jlstevens jlstevens merged commit a4a1c47 into master Sep 4, 2017
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 79.624%
Details
@philippjfr philippjfr deleted the reverse_sort branch Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants