Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using bokeh protocol in the notebook including binary transfer #1894

Merged
merged 4 commits into from Sep 19, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 18, 2017

The bokeh/bokeh#6945 PR adds support for sending bokeh events in the notebook using the regular bokeh protocol. This means we can now take advantage of binary transfer for arrays providing a ~5x speedup, which is particularly noticeable for images. Additionally this will allow us to dynamically add new glyphs to a plot, which means a DynamicMap will be able to return varying numbers of layers with a bit of work.

For now I've left in support for the old way of generating JSON patches and moved some small deprecated bokeh functions into holoviews, as it's not quite clear to me yet whether we can use the protocol for statically embedded data.

@jbednar
Copy link
Member

@jbednar jbednar commented Sep 18, 2017

Additionally this will allow us to dynamically add new glyphs to a plot, which means a DynamicMap will be able to return varying numbers of layers with a bit of work.

That sounds really helpful, and is something that will greatly simplify a lot of user code. What was the change that made that possible?

@philippjfr philippjfr force-pushed the bokeh_binary branch from ad0c619 to 2e6cfe8 Sep 18, 2017
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Sep 18, 2017

What was the change that made that possible?

It's not implemented yet in HoloViews, and will still require a bit of thought. The change in bokeh is that we can now easily send new models to the frontend in the notebook.

Here's a proof of concept:

add_model

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Sep 19, 2017

I think we should get this PR merged as is and I'll separately investigate whether we could/should use the protocol (with or without binary encoding) for embedding data.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 19, 2017

Very happy with the speedup this will give us and the prospect of being able to push new models is very exciting. Merging.

@jlstevens jlstevens merged commit f8bb486 into master Sep 19, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 79.537%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the bokeh_binary branch Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants