Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh protocol improvements #1896

Merged
merged 3 commits into from Sep 20, 2017
Merged

Bokeh protocol improvements #1896

merged 3 commits into from Sep 20, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 19, 2017

Three small fixes to improve event handling with bokeh protocol:

  • Place hold on Document after adding root (avoid RootAdded events)
  • Avoid sending updates without events entirely
  • Only update colormapper if attributes have changed (avoid ModelChanged events and glyph redraws)
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Sep 20, 2017

Ready to merge. At some point we should go through the entire bokeh backend and ensure that we don't needlessly set bokeh model attributes, the colormapper was just a very obvious case to do this since every change to it triggers a full rerender of the glyph.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 20, 2017

Looks good! Merging.

@jlstevens jlstevens merged commit 34ebbb6 into master Sep 20, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on bokeh_protocol_improvements at 79.686%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr added this to the v1.9 milestone Sep 23, 2017
@philippjfr philippjfr deleted the bokeh_protocol_improvements branch Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants