Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for compatibility with bokeh categorical handling #1933

Merged
merged 1 commit into from Sep 28, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 27, 2017

Further fixes for compatibility with the new categorical handling introduced bokeh 0.12.7. Really hoping this is it.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 28, 2017

Are there any tests that could be added to make sure that once it is working properly it stays working?

Otherwise looks fine and I am happy to merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 28, 2017

I'll merge now so I can cut a dev release on the understanding that you are planning to add some more tests in a future PR.

@jlstevens jlstevens merged commit 3680dcb into master Sep 28, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on categorical_fixes at 79.882%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the categorical_fixes branch Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants