Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image grid fixes #2117

Merged
merged 4 commits into from Nov 12, 2017
Merged

Image grid fixes #2117

merged 4 commits into from Nov 12, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Nov 12, 2017

Fixes for #2094, the ImageInterface was not validating that the Image coordinates matched the array shape and the regrid operation was not ensuring the array had the correct orientation before regridding.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Nov 12, 2017

Two important fixes and tests are passing. Merging.

@philippjfr philippjfr merged commit 8cd7b07 into master Nov 12, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 81.088%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the image_grid_fixes branch Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant