Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit parameters when casting Image to QuadMesh #2144

Merged
merged 2 commits into from Nov 25, 2017
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Nov 22, 2017

Due to an oversight the kdims, vdims, group and label aren't inherited when casting an Image to a QuadMesh.

@philippjfr philippjfr force-pushed the quadmesh_img_casting branch from 6ba4e21 to ef2ee84 Nov 24, 2017
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Nov 25, 2017

This is a simple bug fix and I've added a unit test, merging.

@philippjfr philippjfr merged commit 1f60182 into master Nov 25, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 81.119%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr added this to the v1.9.2 milestone Dec 8, 2017
@philippjfr philippjfr deleted the quadmesh_img_casting branch Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant