Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty Distribution and Bivariate elements #2190

Merged
merged 3 commits into from Dec 11, 2017
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 11, 2017

Empty Distribution and Bivariate elements weren't handled correctly.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Dec 11, 2017

Looks good. Ideally we would automate testing of empty data across all elements as has been suggested before. Maybe there should be an issue about that though it will be easiest once all non-annotation elements use interfaces (including histogram types and raster).

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Dec 11, 2017

Maybe there should be an issue about that though it will be easiest once all non-annotation elements use interfaces (including histogram types and raster).

Agreed.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Dec 11, 2017

Please file that issue. Meanwhile I'm going to go ahead and merge.

@jlstevens jlstevens merged commit 627ae8e into master Dec 11, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 81.113%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Dec 11, 2017

Here's the issue: #2192

@philippjfr philippjfr deleted the distribution_empty branch Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants