Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use patch glyph to draw Spread and Area #2225

Merged
merged 1 commit into from Jan 3, 2018
Merged

Use patch glyph to draw Spread and Area #2225

merged 1 commit into from Jan 3, 2018

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 21, 2017

In 1c93aab I originally switched from patches to Band glyphs to draw Area and Spread elements in bokeh. This has a number of consequences, particularly that legends do not work. This PR now uses the patch glyph to draw these elements which makes legends work again and addresses:

@philippjfr philippjfr force-pushed the revert_area_spread branch from 3cf51e5 to 95aca27 Dec 22, 2017
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jan 3, 2018

@jlstevens Ready to merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jan 3, 2018

Looks good. Merging.

@jlstevens jlstevens merged commit d452447 into master Jan 3, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.8%) to 81.202%
Details
@philippjfr
s3-reference-data-cache Tests passing no test data changes required.
Details
@philippjfr philippjfr deleted the revert_area_spread branch Jan 13, 2018
@philippjfr philippjfr added this to the 1.9.3 milestone Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants