Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc updates jan18 #2235

Merged
merged 7 commits into from Jan 3, 2018
Merged

Doc updates jan18 #2235

merged 7 commits into from Jan 3, 2018

Conversation

@ea42gh
Copy link
Contributor

@ea42gh ea42gh commented Jan 1, 2018

some minor changes to documentation.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jan 2, 2018

Thanks for this!

Skimming the diffs, your changes look good: just remember to strip out the metadata/kernel info from the notebooks when you are done.

@ea42gh
Copy link
Contributor Author

@ea42gh ea42gh commented Jan 2, 2018

Thought I had stripped it all out. What was left that could be stripped?
I'll see if I can adapt your strip_kernel.sh script!

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jan 2, 2018

There seems to be this stuff in the PR diff:

image

@ea42gh
Copy link
Contributor Author

@ea42gh ea42gh commented Jan 3, 2018

Figured it out: there were additional edits in another directory that I had forgotten about.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 3, 2018

Looks good, could you just make sure to clear the Gridded Datasets notebook as well. Then this is ready to merge I think.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 3, 2018

Thanks again, all looks great now. I won't wait for tests since it's all text changes (and I suspect the PR needs to be rebased to pass).

@philippjfr philippjfr merged commit d64a28d into holoviz:master Jan 3, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
philippjfr added a commit that referenced this pull request Feb 9, 2018
@philippjfr philippjfr added this to the 1.9.3 milestone Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants