Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous stream fixes #2256

Merged
merged 3 commits into from Jan 11, 2018
Merged

Miscellaneous stream fixes #2256

merged 3 commits into from Jan 11, 2018

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 11, 2018

Includes three small fixes:

  • AreaPlot no longer allows streaming data (because the glyph type doesn't allow it)
  • TablePlot initializes stream callbacks
  • When a data source is shared across multiple plots callbacks are reinitialized
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jan 11, 2018

Ready for review/merge. All uncontroversial small fixes.

Loading

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jan 11, 2018

Looks good to me. Merging.

Loading

@jlstevens jlstevens merged commit 1746f57 into master Jan 11, 2018
4 checks passed
Loading
@ayoungs
Copy link

@ayoungs ayoungs commented Jan 12, 2018

InteractiveBoxTestApp.py.zip
This small test of a stream and Overlaying a bounds on an Image still doesn't work.
I thought it might be related.

Loading

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jan 12, 2018

@ayoungs Are you using HoloViews master? It does work for me.

Loading

@ayoungs
Copy link

@ayoungs ayoungs commented Jan 12, 2018

Now I have it working, using the correct install process and it works as expected! Thank you!

Loading

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jan 12, 2018

We'll have to have a 1.9.3 bug fix release asap.

Loading

@philippjfr philippjfr deleted the misc_streams_fixes branch Jan 13, 2018
@philippjfr philippjfr added this to the 1.9.3 milestone Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants