Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in bokeh TablePlot not escaping dimensions correctly #2336

Merged
merged 2 commits into from Feb 13, 2018

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Feb 12, 2018

The dimension names were not escaped on bokeh's TablePlot, resulting in no data being displayed when plotting Table containing columns with spaces or special characters in them.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Feb 12, 2018

Ready to merge.

@philippjfr philippjfr requested a review from jlstevens Feb 13, 2018
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Feb 13, 2018

Looks good. Merging.

@jlstevens jlstevens merged commit 2fc8743 into master Feb 13, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 81.321%
Details
@philippjfr
s3-reference-data-cache Tests passing no test data changes required.
Details
@philippjfr philippjfr deleted the tabular_dimension_escape_fix branch Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants