Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled auto-indexable on Dataset baseclass #2522

Merged
merged 1 commit into from Apr 4, 2018
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 4, 2018

A while back it seem I accidentally enabled auto-indexing for the Dataset baseclass. The feature was meant as a convenience for 1D Chart types but absolutely should not apply to the baseclass which should accurately represent the underlying data and not fiddle with it. This needs to be called out explicitly in the release notes but should be done immediately since it is a bug and can make it awkward to work with Graph types which allow passing in a list or array of node indices to define an explicit order. This currently will not work correctly because it will add an index automatically.

  • Updated existing tests
@philippjfr philippjfr force-pushed the dataset_autoindex branch from 9fe9cfb to f2271fa Apr 4, 2018
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Apr 4, 2018

Ready to merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Apr 4, 2018

Looks good. I assume you checked _auto_indexable_1d attribute has the right boolean state everywhere it needs it.

Merging.

@jlstevens jlstevens merged commit b8b9441 into master Apr 4, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0007%) to 82.457%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the dataset_autoindex branch Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants