Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed resolving Selection1D in bokeh callback #2586

Merged
merged 1 commit into from Apr 20, 2018
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 20, 2018

In bokeh 0.12.15 the selection API was changed introducing a dedicated Selection model. This PR ensures that the 1D indices are correctly resolved in bokeh server mode.

  • Re-added unit test
@philippjfr philippjfr force-pushed the server_selection1d branch from 34c1966 to cf21047 Apr 20, 2018
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Apr 20, 2018

Ready to merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Apr 20, 2018

Looks good. Merging.

@jlstevens jlstevens merged commit 6a98f62 into master Apr 20, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 82.993%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the server_selection1d branch Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants