Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for empty options method call #2630

Merged
merged 2 commits into from Apr 30, 2018
Merged

Fix for empty options method call #2630

merged 2 commits into from Apr 30, 2018

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 27, 2018

When calling the .options method without any arguments it would previously be an error. This PR ensures that condition is handled appropriately.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Apr 27, 2018

Looks good to me. Merging.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Apr 27, 2018

Unless you want to add a unit test first?

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Apr 30, 2018

Added a quick unit test myself. I'll merge once the tests go green.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Apr 30, 2018

Thanks, I'll go ahead and merge.

@philippjfr philippjfr merged commit 6a4bd34 into master Apr 30, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 83.266%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the options_empty branch Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants