Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed undefined variable bug in XArrayInterface #2674

Merged
merged 3 commits into from May 12, 2018
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 11, 2018

Fixed undefined variable bug when slicing with tuples and added unit tests for grid slicing.

  • Add unit tests
@philippjfr philippjfr force-pushed the xarray_undefined_variable branch from 93384e4 to ef7717b May 12, 2018
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 12, 2018

Ready to merge, test data was updated due to previous issues (so we can ignore the failing push build).

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 12, 2018

I restarted the push build anyway and it is now green. Merging.

@jlstevens jlstevens merged commit 98f09ef into master May 12, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.9%) to 83.378%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr added this to the v1.10.4 milestone May 12, 2018
@philippjfr philippjfr deleted the xarray_undefined_variable branch Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants