Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure plot is rendered into last output in notebook cell #2677

Merged
merged 1 commit into from May 14, 2018

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 12, 2018

This PR ensures that plots are rendered into the last output in a notebook cell ensuring that multiple outputs can be rendered with the IPython display function.

@philippjfr philippjfr changed the title Ensure plot is rendered into last output in notebook Ensure plot is rendered into last output in notebook cell May 12, 2018
@philippjfr philippjfr force-pushed the fix_nb_display branch from 9446451 to e09bc6b May 12, 2018
@philippjfr philippjfr added this to the v1.10.4 milestone May 12, 2018
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 12, 2018

Ready to merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 14, 2018

Tests are green and the change makes sense. I'm not too happy about having to interact with the output display machinery at such a low level but I guess it is unavoidable.

Merging.

@jlstevens jlstevens merged commit 1eed30d into master May 14, 2018
3 of 4 checks passed
3 of 4 checks passed
@philippjfr
s3-reference-data-cache Test data not cached, see details to rebuild.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 83.378%
Details
@philippjfr philippjfr deleted the fix_nb_display branch Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants