Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly check if hover data should be added #2681

Merged
merged 1 commit into from May 14, 2018
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 12, 2018

This PR addresses a class of bugs in the bokeh backend where the data required to display hover information for the element was added if any subplot of the overlay enabled hover information even if the hover for a particular element was not actually displayed. Rather than checking if the bokeh plot object has a HoverTool, it now checks whether the hover tool has been added to the holoviews plot handles, which is the correct way of checking whether hover was enabled.

@philippjfr philippjfr force-pushed the hover_activation_fix branch from dd047aa to 1ebaf3a May 12, 2018
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 14, 2018

Very happy with this PR: it fixes the bug while making the code simpler and easier to read. Merging.

@jlstevens jlstevens merged commit 969fced into master May 14, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 83.376%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the hover_activation_fix branch Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants