Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph.from_networkx method now extract node and edge attributes #2714

Merged
merged 3 commits into from May 22, 2018

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 22, 2018

This PR will allow the Graph.from_networkx method to extract any attributes defined on the nodes and edges and also fixes a bug when trying to plot a Graph with no edges (i.e. only nodes).

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 22, 2018

Ready to review/merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 22, 2018

Looks good. Merging.

@jlstevens jlstevens merged commit 8ce2f52 into master May 22, 2018
4 checks passed
@sorenwacker
Copy link

@sorenwacker sorenwacker commented May 22, 2018

I just cloned and installed holoviews. I still get the same error, when plotting without edges. Am I missing something? Clone the repo and python setup.py install?

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 22, 2018

What does hv.__version__ report? Your example definitely seems to work for me:

screen shot 2018-05-23 at 12 02 02 am

@sorenwacker
Copy link

@sorenwacker sorenwacker commented May 22, 2018

Ok, confirmed it works. Not sure what went wrong the last time.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 23, 2018

Thanks for confirming!

@philippjfr philippjfr deleted the graph_networkx_enhancements branch Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants