Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the conversion interface to discover pandas indexes #2739

Merged
merged 2 commits into from May 28, 2018

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 27, 2018

Allows referencing pandas indexes in .to interface even when Dataset does not declare them as dimensions.

@philippjfr philippjfr force-pushed the pandas_conversion_index branch from 8a158bb to a87257e May 28, 2018
@philippjfr philippjfr changed the title Allow to interface to discover pandas indexes Allow the interface to discover pandas indexes May 28, 2018
@philippjfr philippjfr changed the title Allow the interface to discover pandas indexes Allow the conversion interface to discover pandas indexes May 28, 2018
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 28, 2018

Ready to merge.

for d in vdims]
selected = self._element.clone(kdims=ds_kdims, vdims=ds_vdims)
else:
selected = self._element.reindex(groupby+kdims, vdims)

This comment has been minimized.

@jlstevens

jlstevens May 28, 2018
Contributor

Is the same logic used elsewhere in a context other than the conversion interface? Is any code shared and is it worth abstracting out?

This comment has been minimized.

@philippjfr

philippjfr May 28, 2018
Author Member

No, I cannot think of anywhere this could be reused atm.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 28, 2018

Other than one question in the comment above, this looks fine and I'm happy to merge once you respond.

@jlstevens jlstevens merged commit 766a4f3 into master May 28, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 82.923%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the pandas_conversion_index branch Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants