Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bokeh LayoutPlot bugs #2740

Merged
merged 5 commits into from May 28, 2018
Merged

Fixed bokeh LayoutPlot bugs #2740

merged 5 commits into from May 28, 2018

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 27, 2018

Turns out that the bokeh LayoutPlot implementation was wrong in all kinds of subtle ways so I've completely rewritten the implementation from scratch. The main issue was that AdjointLayout plots were not correctly positioned on the grid. Secondly when enabling tabs AdjointLayout plots were split across multiple tabs.

@philippjfr philippjfr force-pushed the bokeh_layout_fix branch from acc3a35 to cb4fa14 May 27, 2018
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 28, 2018

Ready to review and merge. Also just as a quick note, while I didn't add many new unit tests here there are a number of unit tests for bokeh layouts which are unchanged. Additionally I wrote a little snippet to generate random layouts with combinations of elements and AdjointLayouts, which I tested heavily (must have run it several hundred times to confirm things were working).

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 28, 2018

Turns out that the bokeh LayoutPlot implementation was wrong in all kinds of subtle ways...

Why do I feel deja vu? ;-p

To be fair it has always been very tricky code and I am always happy to see it refactored and improved. I've had to restart a test build for what I assume was a transient but otherwise I am happy to merge.

The only thing I would ask you to consider is whether there is another unit test or two you could add - the more unit tests the better given how tricky it is to get right!

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 28, 2018

Why do I feel deja vu? ;-p

I think this code has been around since I first wrote the bokeh backend, so it has actually held up surprisingly well, unlike the matplotlib version.

The only thing I would ask you to consider is whether there is another unit test or two you could add. The more unit tests the better given how tricky it is to get right!

Added a unit test for the tabs issue, layouts themselves have enough unit tests covering them.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 28, 2018

Added a unit test for the tabs issue, layouts themselves have enough unit tests covering them.

Thanks. I'll merge when the tests go green.

@jlstevens jlstevens merged commit f780840 into master May 28, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 82.986%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the bokeh_layout_fix branch Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants