Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying port and multiple websocket_origins in BokehRenderer #2801

Merged
merged 1 commit into from Jun 13, 2018

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 13, 2018

The BokehRenderer.app method did not allow specifying multiple websocket origins, useful when trying to access the app locally and remotely, and also did not allow setting the port to serve the plot on.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jun 13, 2018

Ready to merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jun 13, 2018

Looks good. Merging.

@jlstevens jlstevens merged commit b3c44e9 into master Jun 13, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.7%) to 83.691%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the bokeh_app_ws_origins branch Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants