Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed value label formatting in HoloMap widgets #2954

Merged
merged 2 commits into from Sep 14, 2018
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 20, 2018

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Aug 20, 2018

Ready to merge or are you planning to add a couple of unit tests?

@philippjfr philippjfr force-pushed the widget_format_bug branch from 21469ad to b9f7560 Sep 14, 2018
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Sep 14, 2018

Added a unit test now.

@philippjfr philippjfr force-pushed the widget_format_bug branch from b9f7560 to 63cfd29 Sep 14, 2018
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 14, 2018

Tests are green. Merging.

@jlstevens jlstevens merged commit 1b668b4 into master Sep 14, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 83.108%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the widget_format_bug branch Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants