Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize FAQ #2959

Merged
merged 2 commits into from Sep 1, 2018
Merged

Reorganize FAQ #2959

merged 2 commits into from Sep 1, 2018

Conversation

@ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Aug 25, 2018

Start FAQ with questions about common things like how to label, re-range, adjust size, legend, and exporting, then some miscellaneous questions, and lastly advanced customization.

Copy link
Member

@jbednar jbednar left a comment

Looks great! I think this ordering makes much more sense. Can you state explicitly that only the ordering has changed, not the content? It's hard to be sure of that because diff doesn't work well for reorderings, but if you say it's true that's good enough for me...

out' (from plot components with their own sizes) and Bokeh building
them 'outside in' (fitting plot components into a given overall size).
Thus there is not currently any way to specify sizes in a way that is
comparable between the two backends.

This comment has been minimized.

@jbednar

jbednar Aug 26, 2018
Member

This bit seems like it should move up to be merged with the earlier question about how to size plots in mpl and bokeh.

This comment has been minimized.

@ahuang11

ahuang11 Aug 27, 2018
Author Collaborator

maybe keep this PR for just reorganization and do that in another PR?

This comment has been minimized.

@jbednar

jbednar Aug 27, 2018
Member

Sounds good!

@ahuang11
Copy link
Collaborator Author

@ahuang11 ahuang11 commented Aug 27, 2018

@jbednar only the ordering has changed!

Here's a quick check with Word:
2340 words on left (original); 2340 words on right (reorganized)
image

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Aug 27, 2018

Makes a lot of sense to me!

@jbednar
Copy link
Member

@jbednar jbednar commented Aug 28, 2018

I can't see why the tests would be failing for this PR; I've restarted them, but to no avail...

@ahuang11
Copy link
Collaborator Author

@ahuang11 ahuang11 commented Aug 28, 2018

======================================================================
FAIL: test_Bokeh_Elements_display_005 (__main__.NBTester)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/ioam/holoviews/doc/nbpublisher/nbtest.py", line 596, in data_comparison
    raise e
AssertionError: Display output mismatch: [{'values_changed': {"root['2211']['roots']['references'][8]['attributes']['data']['y']['__ndarray__']": {'new_value': u'AAAAAAAA8D8/RaOyEf/vP/hTathG/O8/pBrsmp/37z/Hy3Y/HPHvP7vVCye96O8/4T1azoLe7z+cX7fNbdLvP3oPFtl+xO8/FyP8v7a07z9DXnZtFqPvPznGCuiej+8/nVupUVF67z8zPJvnLmPvP0AtcAI5Su8/rI/qFXEv7z8Tv+mw2BLvPwHdUn1x9O4/uAn4Pz3U7j/pC37YPbLuP/doQEF1ju4/Uu8zj+Vo7j+ttMfxkEHuP9iJxLJ5GO4/KOYqNqLt7T9cTA/6DMHtPyQrdZa8ku0/XTsovbNi7T9ZXpQ59TDtP3b+m/CD/ew/dfRs4GLI7D8Z9FMglZHsP6KCjuAdWew/zHkbagAf7D8gGooeQOPrP2mvx3fgpes/NcrrB+Vm6z98EQN5USbrP2av2Iwp5Oo/cly+HHGg6j8/DFMZLFvqPz8/SIpeFOo/zPwljgzM6T8UeQ1aOoLpP3RqejnsNuk/5hEDjibq6D8y+hbP7ZvoP79xvIlGTOg/z8JMYDX75z8uLi8Kv6jnPzysklPoVOc/hXgmHbb/5j/9a9FbLanmPxoqaBhTUeY/KCVibyz45T8cfo2Qvp3lP2jEwb4OQuU/SJqRTyLl5D8JQvuq/obkPwgZGEupJ+Q/+gTLuyfH4z9J2G2af2XjP1yyfZW2AuM/kmBGbNKe4j/3xIzu2DniP5dHOPzP0+E/gVf7hL1s4T+dAPuHpwThP16bdROUm+A/oJtoRIkx4D+3B2uMGo3fPxQEjKRMtd4/DXdeX7Xb3T+7mqhlYQDdP9EMEHpdI9w/lcFbeLZE2z9/gLRUeWTaP7n14xqzgtk/vWOS7XCf2D84AIMFwLrXP9
======================================================================
FAIL: test_Bokeh_Elements_display_006 (__main__.NBTester)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/ioam/holoviews/doc/nbpublisher/nbtest.py", line 596, in data_comparison
    raise e
AssertionError: Display output mismatch: [{'dictionary_item_removed': set(["root['3015']['roots']['references'][62]['subtype']", "root['3015']['roots']['references'][62]['attributes']['min_border_top']", "root['3015']['roots']['references'][62]['attributes']['x_scale']", "root['3015']['roots']['references'][62]['attributes']['y_scale']", "root['3015']['roots']['references'][62]['attributes']['plot_height']", "root['3015']['roots']['references'][62]['attributes']['min_border_left']", "root['3015']['roots']['references'][62]['attributes']['plot_width']", "root['3015']['roots']['references'][62]['attributes']['left']", "root['3015']['roots']['references'][62]['attributes']['renderers']", "root['3015']['roots']['references'][62]['attributes']['x_range']", "root['3015']['roots']['references'][62]['attributes']['y_range']", "root['3015']['roots']['references'][62]['attributes']['below']", "root['3015']['roots']['references'][62]['attributes']['toolbar']", "root['3015']['roots']['references'][62]['attributes

no idea xD

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 28, 2018

Not sure what's up with those test failures, seeing them on other PRs too. I'll update the test data and then rebase this PR once it's fixed.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 1, 2018

@ahuang11 Would you mind rebasing the PR against current master? I've rebuilt the test data so the tests should pass then.

@philippjfr philippjfr merged commit 523ca4e into master Sep 1, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
philippjfr added a commit that referenced this pull request Oct 25, 2018
@philippjfr philippjfr deleted the faq_reorganize branch Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants