Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign int index of coords if no coords in xarray object #2968

Merged
merged 2 commits into from Aug 30, 2018

Conversation

@jsignell
Copy link
Member

@jsignell jsignell commented Aug 30, 2018

I am not sure exactly how this should work if there is one set of coords specified but not another. But this is a start at least following on the ideas here: #2579 (comment)

@jsignell
Copy link
Member Author

@jsignell jsignell commented Aug 30, 2018

@philippjfr, I think the failure is unrelated?

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 30, 2018

Looks like minor pyflakes issues:

tests/core/data/testxarrayinterface.py:281:9: F841 local variable 'expected_ys' is assigned to but never used
tests/core/data/testxarrayinterface.py:289:13: F841 local variable 'img' is assigned to but never used
@philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 30, 2018

The notebook test failure is indeed just transient though.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 30, 2018

Thanks, I'll merge once tests are passing.

@philippjfr philippjfr merged commit 39bdc02 into holoviz:master Aug 30, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 83.009%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 30, 2018

Very happy to have another contributor, thanks again!

@jsignell jsignell deleted the jsignell:assign_coords_if_missing branch Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants