Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support input of strings to theme #2972

Merged
merged 2 commits into from Sep 1, 2018
Merged

Support input of strings to theme #2972

merged 2 commits into from Sep 1, 2018

Conversation

@ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Sep 1, 2018

#2870

image

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 1, 2018

Thanks, been meaning to do this for a while. Could we add a small note about this in the theming section of the Plotting with bokeh user guide?

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 1, 2018

Perfect, will merge once tests pass.

@philippjfr philippjfr merged commit 37925de into master Sep 1, 2018
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 83.009%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 3, 2018

Thanks for the PR @ahuang11 !

philippjfr added a commit that referenced this pull request Oct 25, 2018
@philippjfr philippjfr added this to the v1.10.8 milestone Oct 25, 2018
@philippjfr philippjfr deleted the str_themes branch Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants