Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for bokeh datetime handling #3005

Merged
merged 7 commits into from Sep 17, 2018
Merged

Various fixes for bokeh datetime handling #3005

merged 7 commits into from Sep 17, 2018

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Sep 17, 2018

  • Fixes datetime formatting in Table
  • Fixes datetime formatting in Path hover
  • Fix datetime formatting in Chart hover
  • Add unit tests
@ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Sep 17, 2018

Does this also fix Spikes hover #2882

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Sep 17, 2018

It does now.

@philippjfr philippjfr force-pushed the datetime_bokeh_fixes branch from 6af7e8d to 77aa9aa Sep 17, 2018
@philippjfr philippjfr force-pushed the datetime_bokeh_fixes branch from 77aa9aa to d775c70 Sep 17, 2018
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Sep 17, 2018

Looks good. I'll merge when the tests pass.

@jlstevens jlstevens merged commit 85bb3da into master Sep 17, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 83.148%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
philippjfr added a commit that referenced this pull request Oct 25, 2018
# Conflicts:
#	holoviews/plotting/bokeh/path.py
#	holoviews/plotting/plot.py
#	holoviews/plotting/util.py
#	tests/plotting/bokeh/testpathplot.py
#	tests/plotting/bokeh/testpointplot.py
#	tests/plotting/bokeh/testspikesplot.py
@philippjfr philippjfr added this to the v1.10.8 milestone Oct 25, 2018
@philippjfr philippjfr deleted the datetime_bokeh_fixes branch Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants