Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use robust isfinite utility throughout #3045

Merged
merged 4 commits into from Oct 5, 2018
Merged

Use robust isfinite utility throughout #3045

merged 4 commits into from Oct 5, 2018

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 4, 2018

We use np.isfinite in many places across the code, however the numpy version of this function is not robust to many different types which is why we created the hv.core.util.isfinite utility. Unfortunately this is not yet used everywhere throughout the code, leading to bugs like #3044 and #3040

  • Add unit tests
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Oct 5, 2018

Ready to review and merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 5, 2018

Looks good and the tests are green. Merging.

@jlstevens jlstevens merged commit f2a47f7 into master Oct 5, 2018
4 checks passed
philippjfr added a commit that referenced this issue Oct 25, 2018
# Conflicts:
#	holoviews/core/util.py
#	holoviews/element/raster.py
#	holoviews/operation/stats.py
#	holoviews/plotting/bokeh/stats.py
#	tests/plotting/bokeh/testareaplot.py
@philippjfr philippjfr added this to the v1.10.8 milestone Oct 25, 2018
@philippjfr philippjfr deleted the robust_isfinite branch Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants