Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure QuadMesh with xarray handles datetime range #3081

Merged
merged 2 commits into from Oct 11, 2018
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 10, 2018

When using the xarray interface with a QuadMesh the range method would break on the datetimes.

  • Adds unit tests
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Oct 10, 2018

Looks good. I'll merge when the tests pass.

@philippjfr philippjfr force-pushed the xarray_binned_range branch from 07d0322 to 3329815 Oct 10, 2018
@jlstevens jlstevens merged commit a65ef97 into master Oct 11, 2018
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.3%) to 88.588%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
philippjfr added a commit that referenced this pull request Oct 25, 2018
# Conflicts:
#	holoviews/core/data/xarray.py
@philippjfr philippjfr added this to the v1.10.8 milestone Oct 25, 2018
@philippjfr philippjfr deleted the xarray_binned_range branch Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants