Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh charts #339

Merged
merged 24 commits into from Dec 20, 2015
Merged

Bokeh charts #339

merged 24 commits into from Dec 20, 2015

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 7, 2015

This PR adds plotting classes for two Bokeh chart types, Bars, which already exist in matplotlib and box plots, which has also been added for matplotlib. Currently the Element name is BoxWhisker but I'd appreciate something better that's not BoxPlot (since that kind of breaks our naming convention). The PR is not quite ready but it already mostly works.

Here are some demos of the new supported plots: Bokeh Charts Notebook

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Dec 7, 2015

Great! Target this for 1.4.1?

@jbednar
Copy link
Member

@jbednar jbednar commented Dec 8, 2015

Looks good. Box would follow the convention, but we've already used that for another Element. BoxWhisker may be the best thing left; BoxAndWhiskers is too long, and BaW is too obscure.

@philippjfr philippjfr force-pushed the bokeh_charts branch from 39a81e0 to 734ea36 Dec 19, 2015
@philippjfr philippjfr force-pushed the bokeh_charts branch from 3e72483 to 4c860d2 Dec 19, 2015
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Dec 20, 2015

Now ready for merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Dec 20, 2015

Ok, tests are passing now so I'll merge.

Edit: Having skimmed over the changes and additions, they are look ok to me. I will note that although the title of the PR is currently 'Bokeh Charts', other things are happening here (e.g adding BoxWhisker support matplotlib and implementing side plots). It is all good stuff but in future I would prefer to see separate, orthogonal features implemented as separate PRs.

jlstevens added a commit that referenced this pull request Dec 20, 2015
Added BoxWhisker element and added support for Bars in Bokeh
@jlstevens jlstevens merged commit 44d8c3b into master Dec 20, 2015
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 70.531%
Details
@jlstevens jlstevens deleted the bokeh_charts branch Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants