Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of characters that have no uppercase #3403

Merged
merged 5 commits into from Jan 16, 2019
Merged

Conversation

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jan 15, 2019

Fix to address #2096: identifiers can contain unicode in Python 3 and not all unicode characters have an equivalent uppercase letter.

This example now works:

image

One thing I want to do before this PR is merged is add a few unit tests.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 15, 2019

Looks good, happy to merge with some unit tests.

@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented Jan 15, 2019

I've added five unit tests. Happy to see this PR merged when Travis goes green.

@philippjfr philippjfr merged commit 2d015dd into master Jan 16, 2019
4 checks passed
@philippjfr philippjfr deleted the unicode_upper_fix branch Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants