Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved attribute handling in Graph.from_networkx #3432

Merged
merged 6 commits into from Jan 27, 2019
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 25, 2019

This PR improves Graph.from_networkx in a number of ways. First of all it makes sure that non-scalar attributes and indexes (e.g. lists, tuples or dictionaries) do not break the Graph. Secondly this PR will allow passing in a dictionary of node positions which is the canonical way to specify node positions in networkx.

  • Handle non-scalar attributes
  • Handle dictionary node positions
@philippjfr philippjfr force-pushed the from_networkx_fixes branch from 2194f3f to 6485c35 Jan 25, 2019
@philippjfr philippjfr force-pushed the from_networkx_fixes branch from af3635d to 5eb31d7 Jan 27, 2019
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jan 27, 2019

Merging to make sure the holoviews release is ready in time.

@philippjfr philippjfr merged commit 2aa0a25 into master Jan 27, 2019
5 checks passed
5 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 90.076%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the from_networkx_fixes branch Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant