Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added underscores to Opts attributes #3438

Merged
merged 2 commits into from Jan 29, 2019
Merged

Conversation

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jan 28, 2019

Addresses #3437.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 29, 2019

Looks good.

@philippjfr philippjfr merged commit dd18680 into master Jan 29, 2019
5 checks passed
5 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 90.076%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the opts_underscore_attributes branch Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants