Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for style updates in matplotlib #3442

Merged
merged 1 commit into from Jan 29, 2019
Merged

Fixes for style updates in matplotlib #3442

merged 1 commit into from Jan 29, 2019

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 29, 2019

This PR ensures that styles are updated generally in the matplotlib backend and also fixes a concrete bug where updating a scalar size on a Point/Scatter plot raised an error.

  • Fixes #3439
  • Adds unit test
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jan 29, 2019

Looks good. Merging.

@jlstevens jlstevens merged commit ed1cc85 into master Jan 29, 2019
5 checks passed
5 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on update_styles at 89.856%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the update_styles branch Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants