Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain Element._plot_id on redim #3478

Merged
merged 1 commit into from Feb 8, 2019
Merged

Retain Element._plot_id on redim #3478

merged 1 commit into from Feb 8, 2019

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Feb 8, 2019

As long as the data itself does not change redim should not change the plot_id and therefore break links between plots. This PR checks whether the dimension names change before restoring the previous plot_id on a redim, since the only redim change that necessitates a change to the data is a change in the dimension names.

@philippjfr philippjfr merged commit 02cf145 into master Feb 8, 2019
6 checks passed
6 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on redim_plot_id at 89.833%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the redim_plot_id branch Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant