Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic overlay #367

Merged
merged 6 commits into from Dec 20, 2015
Merged

Dynamic overlay #367

merged 6 commits into from Dec 20, 2015

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 18, 2015

This PR makes it possible to use return Overlays with changing keys in a DynamicMap callback. It's a sensitive change, which will require some more testing.

Note that while it now displays everything certain things do not yet work:

  • Legends do not yet change to reflect the new NdOverlay key or Overlay label
  • In matplotlib styles will not consistently update.

And certain things cannot work:

  • Cyclic styles cannot work with a DynamicMap as the total ordering is required during instantiation. Could consider raising a warning when an Element returned from a DynamicMap is given a cyclic style.
  • You cannot return more Elements or different types of Elements than are supplied during instantiation.
@philippjfr philippjfr force-pushed the dynamic_overlay branch from 102dfa3 to 9fa1ec2 Dec 19, 2015
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Dec 20, 2015

We've opened some issues to improve the validation for DynamicMap return types and warning the user. For now though this PR is ready for merge.

jlstevens added a commit that referenced this pull request Dec 20, 2015
Improved display of Overlays returned by DynamicMaps
@jlstevens jlstevens merged commit 4d645b4 into master Dec 20, 2015
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 70.66%
Details
@philippjfr philippjfr deleted the dynamic_overlay branch Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants