Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hv.help() for non-hv objects #3689

Merged
merged 1 commit into from May 3, 2019
Merged

Fixed hv.help() for non-hv objects #3689

merged 1 commit into from May 3, 2019

Conversation

@jbednar
Copy link
Member

@jbednar jbednar commented May 3, 2019

hv.help() was meant to fall back to pydoc for anything it doesn't understand, but that has apparently been broken for some time (see below). Looks like it was because pydoc was deleted from the module namespace, presumably to clean up our API. To achieve the same thing while also working properly, did a local import of pydoc just where it was needed.

Screen Shot 2019-05-03 at 12 40 18 PM

@philippjfr philippjfr added this to the v1.12.3 milestone May 3, 2019
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 3, 2019

Thanks for the fix. Happy to merge when the tests pass (I restarted one, presumably failed due to a transient).

@jlstevens jlstevens merged commit f055634 into master May 3, 2019
4 checks passed
@philippjfr philippjfr deleted the pydoc branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants