Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly resample colorcet colormaps #3977

Merged
merged 1 commit into from Sep 20, 2019
Merged

Conversation

@philippjfr
Copy link
Member

philippjfr commented Sep 20, 2019

Fixes #3964

Cc: @jsignell @jbednar

@philippjfr philippjfr added the bug label Sep 20, 2019
@philippjfr philippjfr force-pushed the philippjfr/colorcet_ncolors branch from e49a784 to a874922 Sep 20, 2019
@philippjfr philippjfr merged commit 5010cbd into master Sep 20, 2019
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 88.129%
Details
@philippjfr philippjfr deleted the philippjfr/colorcet_ncolors branch Sep 20, 2019
@jbednar

This comment has been minimized.

Copy link
Member

jbednar commented Sep 20, 2019

Thanks! Instead of hardcoding "glasbey" here, maybe it would be more general and extensible to use the database of metadata that we already have about the colormaps? (hv.plotting.util.list_cmaps("Categorical"))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.