Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Dynamic utility subscribes to dependent function #3980

Merged
merged 4 commits into from Sep 20, 2019

Conversation

@philippjfr
Copy link
Member

philippjfr commented Sep 20, 2019

Fixes issue with #3975

While dependent functions were resolved without this, the DynamicMap did not actually subscribe changes in the dependencies and therefore wouldn't trigger an update until something else changed.

@philippjfr philippjfr merged commit 5c4bf7b into master Sep 20, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on philippjfr/fix_dependent_function_subscribe at 88.136%
Details
philippjfr added a commit that referenced this pull request Sep 20, 2019
@jbednar

This comment has been minimized.

Copy link
Member

jbednar commented Sep 20, 2019

Thanks! I hadn't noticed any problem in my quick testing, so I'm glad you caught this!

@jbednar jbednar deleted the philippjfr/fix_dependent_function_subscribe branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.