Warning if __new__ implicitly casts to DynamicMap #4301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlstevens
changed the title
jlstevens
changed the title
jbednar
reviewed
Mar 18, 2020
|
@philippjfr @jbednar Ready to review and maybe merge once the tests go green. |
philippjfr
reviewed
Mar 18, 2020
philippjfr
reviewed
Mar 18, 2020
Co-Authored-By: Philipp Rudiger <prudiger@anaconda.com>
jbednar
approved these changes
Mar 18, 2020
|
Second PR build is about to pass and all the other tests are green. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the warning discussed with @jbednar and @philippjfr. The idea is to make the intuitive thing work while alerting the user that some magic is happening in the background. In a sense, this functionality is very similar to how we approach
.collate.Currently work in progress: we can discuss how to improve the warning message and I will format better suggestions for using
.applywhenkdims,vdimsandkwargsare not empty.