Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Bokeh tutorial/code improvements #477

Merged
merged 9 commits into from Feb 8, 2016
Merged

Small Bokeh tutorial/code improvements #477

merged 9 commits into from Feb 8, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Feb 8, 2016

Minor fixes for the Bokeh tutorials removing additional Element examples, which do not yet work, i.e. sidebar of ErrorBars and overlay of VectorFields. Also added bootstrap based warning messages to warn that Tutorials can take a minute to render because there's so many plots on the page.

"<div class=\"alert alert-info\" role=\"alert\">\n",
" This tutorial contains a lot of bokeh plots, which may take a little while to load and render.\n",
"</div>\n",
"\n",
Copy link
Contributor

@jlstevens jlstevens Feb 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does help but I was also thinking of submitting an issue to suggest some sort of loading placeholder for Bokeh plots. Would this be feasible/worthwhile?

Loading

Copy link
Member Author

@philippjfr philippjfr Feb 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does sound nice but I also don't know how feasible it is.

Loading

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Feb 8, 2016

I've made a few comments but otherwise it looks ok to me. That said, there are a number of code changes that I assume will affect more than just the Bokeh tutorial.

Loading

@philippjfr philippjfr changed the title Small Bokeh tutorial improvements Small Bokeh tutorial/code improvements Feb 8, 2016
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Feb 8, 2016

Ready to merge now.

Loading

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Feb 8, 2016

Ok. Tests are passing so I'll merge now.

Loading

jlstevens added a commit that referenced this issue Feb 8, 2016
Small Bokeh tutorial/code improvements
@jlstevens jlstevens merged commit 40d3fd5 into master Feb 8, 2016
4 checks passed
Loading
@jlstevens jlstevens deleted the bokeh_tutorials branch Feb 9, 2016
@philippjfr philippjfr added this to the 1.4.3 milestone Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants