Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured initial dynamicmap values are escaped correctly in widgets #478

Merged
merged 1 commit into from Feb 9, 2016

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Feb 9, 2016

The widgets require slightly different escaping when using DynamicMap, this PR ensures they are escaped correctly to avoid a bug where all sliders would have to be moved from their default position for DynamicMap to work.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Feb 9, 2016

Doesn't look too bad. I'm happy to merge as soon as the tests pass.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Feb 9, 2016

Ready to merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Feb 9, 2016

Ok. Merging now.

jlstevens added a commit that referenced this issue Feb 9, 2016
Ensured initial dynamicmap values are escaped correctly in widgets
@jlstevens jlstevens merged commit adb56eb into master Feb 9, 2016
4 checks passed
@jlstevens jlstevens deleted the dynamic_fix branch Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants